From b3582d589999953bfb9f96c810fab96f794d51ff Mon Sep 17 00:00:00 2001
From: Felix Kleinert <f.kleinert@fz-juelich.de>
Date: Fri, 28 Jan 2022 10:19:05 +0100
Subject: [PATCH] include dropna in skill scores based on mse

---
 mlair/run_modules/post_processing.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/mlair/run_modules/post_processing.py b/mlair/run_modules/post_processing.py
index 304f004c..a351dd92 100644
--- a/mlair/run_modules/post_processing.py
+++ b/mlair/run_modules/post_processing.py
@@ -969,10 +969,16 @@ class PostProcessing(RunEnvironment):
         wind_sectors = self.data_store.get("wind_sectors", "general")
         h_sector_skill_scores = []
         for sec in wind_sectors:
-            h_sector_skill_scores.append(statistics.skill_score_based_on_mse(
-                ds.where(self.upstream_wind_sector.squeeze() == sec),
-                obs_name=self.observation_indicator, pred_name=self.model_display_name,
-                ref_name=ref_name).assign_coords({"sector": sec})
+            h_sector_skill_scores.append(
+                # statistics.SkillScores(None).general_skill_score(ds.where(self.upstream_wind_sector.squeeze() == sec),
+                #                                                  forecast_name=self.model_display_name,
+                #                                                  reference_name=ref_name,
+                #                                                  observation_name=self.observation_indicator)
+                statistics.skill_score_based_on_mse(
+                    ds.where(self.upstream_wind_sector.squeeze() == sec).dropna(dim=self.index_dim),
+                    obs_name=self.observation_indicator, pred_name=self.model_display_name,
+                    ref_name=ref_name).assign_coords({"sector": sec}
+                                                     )
                                          )
         sector_skill_scores = xr.concat(h_sector_skill_scores, dim="sector")
         sector_skill_scores = sector_skill_scores.assign_attrs({f"reference_model": ref_name})
-- 
GitLab