From b4d8f6a13002f9c854100e415ce9b57fe9223a04 Mon Sep 17 00:00:00 2001
From: Mathias Wagner <mathiasw@nvidia.com>
Date: Thu, 14 Nov 2019 21:26:32 +0100
Subject: [PATCH] remove lefttover TODOs
---
4-GPU/HandsOn/.master/C/task6/poisson2d.solution.c | 5 +----
4-GPU/HandsOn/Solution/C/task6/poisson2d.solution.c | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/4-GPU/HandsOn/.master/C/task6/poisson2d.solution.c b/4-GPU/HandsOn/.master/C/task6/poisson2d.solution.c
index 8deb2b2..5556ba3 100644
--- a/4-GPU/HandsOn/.master/C/task6/poisson2d.solution.c
+++ b/4-GPU/HandsOn/.master/C/task6/poisson2d.solution.c
@@ -133,8 +133,7 @@ int main(int argc, char **argv) {
MPI_Barrier(MPI_COMM_WORLD);
if (rank == 0) printf("Parallel execution.\n");
- //TODO: measuring the MPI time with asynchronous compute is not well defined. Remove it here and belows.
- double mpi_time = 0.0;
+ // double mpi_time = 0.0;
double start = MPI_Wtime();
int iter = 0;
real error = 1.0;
@@ -159,8 +158,6 @@ int main(int argc, char **argv) {
while (error > tol && iter < iter_max) {
error = 0.0;
-//TODO: Check which parts in the while loop can be executed asynchronously by adding the async keyword
-//You might also need to use wait
#pragma acc parallel loop present(A, Anew, rhs) async
for (int iy = iy_start; iy < iy_end; iy++) {
for (int ix = ix_start; ix < ix_end; ix++) {
diff --git a/4-GPU/HandsOn/Solution/C/task6/poisson2d.solution.c b/4-GPU/HandsOn/Solution/C/task6/poisson2d.solution.c
index 8deb2b2..5556ba3 100644
--- a/4-GPU/HandsOn/Solution/C/task6/poisson2d.solution.c
+++ b/4-GPU/HandsOn/Solution/C/task6/poisson2d.solution.c
@@ -133,8 +133,7 @@ int main(int argc, char **argv) {
MPI_Barrier(MPI_COMM_WORLD);
if (rank == 0) printf("Parallel execution.\n");
- //TODO: measuring the MPI time with asynchronous compute is not well defined. Remove it here and belows.
- double mpi_time = 0.0;
+ // double mpi_time = 0.0;
double start = MPI_Wtime();
int iter = 0;
real error = 1.0;
@@ -159,8 +158,6 @@ int main(int argc, char **argv) {
while (error > tol && iter < iter_max) {
error = 0.0;
-//TODO: Check which parts in the while loop can be executed asynchronously by adding the async keyword
-//You might also need to use wait
#pragma acc parallel loop present(A, Anew, rhs) async
for (int iy = iy_start; iy < iy_end; iy++) {
for (int ix = ix_start; ix < ix_end; ix++) {
--
GitLab