Feature/fix warnings

We should be able to compile using -Wall -Wextra -Werror.

Currently the easy fixes are done, but in the Unstructured load balancer many variables are declared (and set), but not used. I assume, this is the case due to the in progress state of the method.

Other open problems are:

• unused parameters for some implementations of setAdditionalData. If these declaration have to be there we may silence them with proper annotations (for GCC: __attribute__((unused))(ref), which should be put into a compiler dependant preprocessor switch to also set this for clang etc. as well as for readability. Maybe known_unused is a good keyword)
• ignored const on function return (ALL_LB.hpp:163: const int getNVertices() { return vertices.size(); })

This branch should only be merged to refactor after !9 (merged) has been merged!.

changed the description

added 2 commits

• e1c7ff6e - fix ignored-qualifier warning
• f6763476 - use known_unused as attribute to silence unused variable warnings

Compare with previous version

The ignored const on function return is irrelevant since a value is returned. Remvoed the qualifier.

I have (for now) implemented the known_unused keyword to declare some variables which are known to be unused. This only works for GCC at the moment and breaks compatibility with other compilers!

added 1 commit

• 7bad1d95 - support clang for known_unused

Compare with previous version

added 1 commit

• 05e36863 - add intel compiler to compiler detection

Compare with previous version

added 2 commits

• 2f4cb33a - fix typo in compiled detection
• 4c9f87d5 - decorated the in progess ALL_Unstructured with unused variables

Compare with previous version

Since I am not too familiar with C++ one should check if there are bac C mannerism in the changed code.

Still TODO:

• fortran interface (not sure if we can fix/silence those due to MPI
• check Voronoi part (and i remember voro++ being noisy)

And one particular thing to check is how to fix the signed/unsigned comparisons in the for loops. I have just c cast them to int for now, but probably jut the correct type should be used for the loop counter. Which is std::Vector::size_type?

The warnings from voro++.hh can be silenced (at least in GCC) with pragmas, as shown in ALL_Voronoi.hpp. Compiling the voro library still throws lots of errors if warnings are enabled globally with CMAKE_CXX_FLAGS, but that might not matter, since the user's program would not throw those on compilation.

added 5 commits

• 988e4161 - some more potentially unused variables in fortran interface
• 6f126200 - fix more warnings
• 8db272a3 - fix exception references and known_unused
• 18599629 - fix some warnings in ALL_test.cpp
• f3c69c69 - silence warnings from voro++ include in GCC

Compare with previous version

added 4 commits

• f3c69c69...aa3e9ccb - 2 commits from branch refactor
• 90f28255 - Merge branch 'refactor' into feature/fix_warnings
• 31b0fb15 - "fix" warnings in one test

Compare with previous version

resolved all threads

unmarked as a Work In Progress

merged