Dead code in sion_paropen_mpi
Test coverage has revealed parts of sion_paropen_mpi
to be dead code, namely the block starting here: src/parlib/sion_mpi_gen.c@2172#L192. The problem is that numFiles <= 0
is impossible at that point. If numFiles <= 0
when entering the function, the true
branch is taken here src/parlib/sion_mpi_gen.c@2172#L129 and numFiles
is set to a positive number by _sion_get_info_from_splitted_comm_mpi
.
Things seem to be working without this code though, so is this a bug or legitimately dead code that can be removed?