code review is done regularly
Perhaps a good starting point to this topic:
https://yalantis.com/blog/code-review-via-gitlab-merge-requests-code-review-must/
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sabine Schröder added .todo discussion enhancement labels
added .todo discussion enhancement labels
- Sabine Schröder removed .todo label
removed .todo label
- Sabine Schröder added .doing label
added .doing label
- Author Owner
Niklas and Sabine did a code review already twice:
March 30th, 2021
- restructure repository (mv directories harvesting, imports_from_TOAR1 to repository toar-db-data)
- update README.md
April 15th, 2021:
- delete "coding: utf-8" from all source files (standard in python3)
- check assignments "=" in code, within arguments (use same style everywhere)
- data/crud.py: pd.read_csv -- only specify arguments which vary from the defaults
Starting with May 6th, 2021
the regular code review will take place
every first Thursday in a month at 1pm.Edited by Sabine Schröder - Sabine Schröder removed .doing label
removed .doing label
- Sabine Schröder added .done label
added .done label
- Sabine Schröder closed
closed
- Sabine Schröder marked this issue as related to #59 (closed)
marked this issue as related to #59 (closed)
- Author Owner
May 6th, 2021:
- code reviews will be done only when merging into master branch
- to avoid pending merge requests (in case the reviewer is ill, on vacation, ...),
a separate issue (#59 (closed)) has been opened;
this issue has committer and reviewer as participants;
when requesting a merge into master branch, this issue has to be given within the merge request's message
ToDo: Find out, how to give issue number within merge request's message
- Sabine Schröder mentioned in commit c988f699
mentioned in commit c988f699
- Sabine Schröder mentioned in merge request !17 (merged)
mentioned in merge request !17 (merged)
- Sabine Schröder mentioned in commit bb61f5ee
mentioned in commit bb61f5ee
- Sabine Schröder mentioned in merge request !18 (merged)
mentioned in merge request !18 (merged)
Please register or sign in to reply