Various small fixes for issues discovered by gcc8

INSTALL.md

@@ -27,6 +27,18 @@ autoreconf -ivf
 make
 ```
 
+Depending on which branch you build, the default configure argumenst may include options to enable the
+gcc/llvm address sanitizer. To disable, please configure with
+```
+--disable-asan
+```
+If you have the address sanitizer enabled, that may (depending on the compiler) also turn on the leak checker, and since 
+we are not fully memory leak-free at this point may trigger exit-time failures. To disable it, set the environment variable
+```
+LSAN_OPTIONS=detect_leaks=0
+```
+
+
 Cray-specific (jupiter)
 -----------------------
 Do not use one of the craype-network-ofi\* modules at this time.

configure.ac

@@ -72,7 +72,7 @@ AM_PROG_CC_C_O
 AM_PROG_AR
 
 dnl things suggested by autoscan
-AC_CHECK_FUNCS([atexit bzero clock_gettime dup2 floor ftruncate gethostname getpagesize memmove memset mkdir munmap putenv regcomp select strcasecmp strchr strdup strerror strncasecmp strspn strtol strtoul strtoull strtoumax],[],
+AC_CHECK_FUNCS([atexit bzero clock_gettime dup2 ftruncate gethostname getpagesize memmove memset mkdir munmap putenv regcomp select strcasecmp strchr strdup strerror strncasecmp strspn strtol strtoul strtoull strtoumax],[],
 		[AC_MSG_ERROR([Missing essential system library function])])
 AC_CHECK_HEADERS([fcntl.h float.h limits.h netdb.h netinet/in.h stddef.h sys/param.h sys/socket.h sys/time.h],[],
 		[AC_MSG_ERROR([Missing essential system header function])])

maestro/groups.c

@@ -465,6 +465,8 @@ mstro_group_demand(mstro_group g)
   }
   assert(g->state & MSTRO_GROUP_STATE_REQUIRED);
 
+  Mstro__Pool__GroupMembers *members = NULL;
+
   mstro_status s = mstro_cdo_demand(g->group_cdo);
   if(s!=MSTRO_OK) {
     ERR("Failed to DEMAND proxy CDO for group %s\n", g->name);
@@ -483,8 +485,8 @@ mstro_group_demand(mstro_group g)
   assert(type==MSTRO_CDO_ATTR_VALUE_blob);
 
   const mstro_blob *member_blob = (const mstro_blob*)blob;
-  Mstro__Pool__GroupMembers *members 
-      = mstro__pool__group_members__unpack(NULL, member_blob->len, member_blob->data);
+  members = mstro__pool__group_members__unpack(
+		  NULL, member_blob->len, member_blob->data);
 
   if(members==NULL) {
     ERR("NULL members structure in group %s\n", g->name);

tests/check_uuid.c

@@ -55,6 +55,7 @@ CHEAT_TEST(uuid_create_export,
  
        char *str = NULL;
        cheat_assert(UUID_RC_OK==uuid_export(uuid1,UUID_FMT_STR,&str, NULL));
+       free(str);
        cheat_assert(UUID_RC_OK==uuid_destroy(uuid1));
        )
 

transport/transport.c

@@ -363,8 +363,9 @@ mstro_transport_execute(
 
     /* layout-related attributes and a few more are always precious, as
      * transformations will have handled them */
-    const size_t num_precious_attr = 7;
-    const char *precious_attributes[num_precious_attr] = {
+#define NUM_PRECIOUS 7
+    const size_t num_precious_attr = NUM_PRECIOUS;
+    const char *precious_attributes[NUM_PRECIOUS] = {
       MSTRO_ATTR_CORE_CDO_RAW_PTR,
       MSTRO_ATTR_CORE_CDO_MAMBA_ARRAY,
       MSTRO_ATTR_CORE_CDO_SCOPE_LOCAL_SIZE,